-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update melange convert python to have tests and produce subpackages for each python version. #1464
base: main
Are you sure you want to change the base?
Conversation
It'd be helpful if you attached the output of a run of convert python with this in the PR for reference. I'm also wondering if we should be doing this through a go template - see Line 147 in 1868224
|
Will do.
Certainly something to look into for future changes for sure. I hadn't noticed that when I was looking through things. |
382cc76
to
87605da
Compare
To do this add data and vars to use for substitution as well as a subapckage and remove the unversioned python dep since it will be generated correctly as part of the build.
87605da
to
444e7a0
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would also want @jonjohnsonjr to review and approve
This is way helpful. some things I noticed yesterday that I'd like to have (one from justin)
|
@pnasrat pointed out that this is probably more work than it is worth at this point. |
Initially I thought maybe we'd have to build it to do this. But we could probably download the actual artifact and tar tf it to see if it generates a bin.
This is super easy I can add that no problem
ditto |
96cbb22
to
c3f5b4b
Compare
Pull request was converted to draft
…lange-conversion-script
@justinvreeland I just fixed up the merge conflict to trigger another build and looks like it is passing CI. Is there anything blocking this moving to review? |
Melange Pull Request Template
Functional Changes
Notes:
I have not tried to build all of Wolfi but this change shouldn't effect builds and the packages I have built with these changes build correctly. Including the results from the convert changes. (Though some python packages need some changes because they produce binaries or need C extensions built or something)
Additional Notes:
The pipeline that this convert script uses is in Wolfi's repo not this one. I'm not sure why that is but I'm happy to add it to this PR if that's desired.
This hardcodes python3.{10,11,12} for use in the generated yaml, it is not ideal but it would be nice if it was more configurable. Different melange users might want to specify a different python versions in particular I might want to have a file in Wolfi that specifies the supported python3 versions and reads that to generate the range if that file is found instead of using the the hardcoded set but my brief look at melange didn't find anything similar to model it off of.