sca: Allow non-executable .so to provide/vendor #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For executable files, we expect the executable bit to be set; however, the exec bit doesn't actually need to be set for shared objects. When we are computing provided/vendored .so files, we were ignoring any that didn't have the exec bit set, which meant a lot of python packages were unexpectedly pulling in dependencies when they should have been self-provided. Signed-off-by: Jon Johnson <[email protected]>
|
X-ref: wolfi-dev/os#24325 If I drop the diff --git a/airflow.yaml b/airflow.yaml
index 0c08c1ead..5711a33c3 100644
--- a/airflow.yaml
+++ b/airflow.yaml
@@ -3,11 +3,6 @@ package:
version: 2.9.3
epoch: 0
description: Platform to programmatically author, schedule, and monitor workflows
- options:
- # There is a dependency on libarrow.so although it
- # is provided in the virtual environment. Enabling no-depends
- # works around this
- no-depends: true
copyright:
- license: Apache-2.0Then melange erroneously treated these as 14,18d13
< depend = so:libarrow.so.1700
< depend = so:libarrow_acero.so.1700
< depend = so:libarrow_dataset.so.1700
< depend = so:libarrow_flight.so.1700
< depend = so:libarrow_substrait.so.1700
28d22
< depend = so:libparquet.so.1700
36a31,34
> # vendored = so:libarrow.so.1700=1700
> # vendored = so:libarrow_acero.so.1700=1700
> # vendored = so:libarrow_dataset.so.1700=1700
> # vendored = so:libarrow_flight.so.1700=1700
39a38
> # vendored = so:libarrow_substrait.so.1700=1700
63a63
> # vendored = so:libparquet.so.1700=1700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For executable files, we expect the executable bit to be set; however, the exec bit doesn't actually need to be set for shared objects. When we are computing provided/vendored .so files, we were ignoring any that didn't have the exec bit set, which meant a lot of python packages were unexpectedly pulling in dependencies when they should have been self-provided.