Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding merge_direct_overlaps() method #131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ramalh
Copy link

@Ramalh Ramalh commented Aug 25, 2023

Greetings dear developers,

I have been using intervaltree for my project which is about biology.
But when I use merge_overlaps() method, it merges all intervals that overlap directly or indirectly.
Assume there are three regions in a genome called intervalA, intervalB, and intervalC. intervalB overlaps with both
intervalA and intervalC but these two are not.
So what I needed to merged them like this: intervalAB and intervalBC. And I wrote a method called merge_direct_overlaps(). I have tested it with four additional test function for mentioned python version and it passed all.

I tried to make the insertion as smooth as possible; such as copying the structure of merge_overlaps() method for this new method, adding 4 test functions which is highly similar to test functions of merge_overlaps(), and lastly adding a brief info about the method to README.md file.

Feedback is welcome

@Ramalh Ramalh marked this pull request as draft August 27, 2023 17:50
@Ramalh Ramalh marked this pull request as ready for review August 27, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant