-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add broadcasts for sequences #2971
Conversation
* Fixed typing and broadcasting issue for sequence types * Fixed errors
* Sequence item types for Load Video * Ignore type error
Whats the status on this? Is there anything that needs to be actively addressed? If something is wrong, please tell me what i should change |
Same as before, no?
So please fix the underlying issue, because if we are running one iteration, that'll be a huge problem because it'll run nodes with side effects. |
That's not at all what's happening. The problem I mentioned is if you run the chain, stop it, then start again. It is not running an iteration when it auto runs. It's just running the node function, which returns the generator object. it seemed that keeping the same object in the cache treats it the same way as pausing, which is why I needed to dump the cache. I'm not sure how you got that we're running an iteration from anything I said |
Oh. Well, this PR is about broadcasts, so I assumed that change had something to do with it... I assumed that you discovered this bug because of broadcasts ( |
Correct |
Alright, then it should be good. |
Wanted to make this a draft to get some early feedback. There's a few things that still have to be done, mainly fixing the issue where it shows the previous broadcast value, which I have been unable to find even a shred of a lead at what's causing it.
Note: I decided to store the lengths in the outputNarrowing map under the "length" key. This is obviously not an ideal solution, but the alternative was duplicating all the same kind of code for storing it in a new map, and i felt it was similar enough to just throw it in there, at least for a proof of concept first.
TODO: