add hover effect to weather and error icons #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetzwergDE
requested changes
Oct 6, 2024
There was a problem hiding this comment.
Interesting script, that should work, but for some reason isn't (tested build and run in Quest 3), maybe some other settings (rigidbody,etc.) are blocking the script from working...
keep in mind, that the clouds already have a floating animation provided (not as script, but as unity animations)
Comment on lines
+7
to
+8
| public float amplitude = 2f; | ||
| public float speed = 0.5f; |
There was a problem hiding this comment.
Variable values instead of hard coded would be more flexible, but the given values should do the job
Comment on lines
+12
to
+14
| Vector3 p = transform.position; | ||
| p.y = amplitude * Mathf.Cos(Time.time * speed); | ||
| transform.position = p; |
There was a problem hiding this comment.
the idea should work, simple mathematics, using the cos is a good idea! 👍
(for better extensibility and readability you can put the code in a new function)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Resolves Issue #115)
This adds a nice hover effect to all weather icon and error icon.
This makes the scene less static, thus visually more immersive.
The script HoverAnimation includes the code for the hover effect. This is attached to each weather and error icon as a component.