Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixed declaration warnings in SCSS #8595

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Sep 25, 2024

Changes

  • Change order of CSS declarations to fix Sass deprecation warnings.

How to test this PR

  1. yarn build shouldn't have any deprecation warnings for mixed declarations. Check the touched apps for any visual changes. They should be unchanged to prod.

@anselmbradford anselmbradford force-pushed the ans_fix_deprecated branch 2 times, most recently from 5bbbcde to e02aee4 Compare September 26, 2024 16:50
Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@anselmbradford anselmbradford added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit ebdd13e Oct 15, 2024
11 checks passed
@anselmbradford anselmbradford deleted the ans_fix_deprecated branch October 15, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants