Added support for a minimum duration for a toast notification #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now set a minimum duration for the notification to display. This allows you to keep notifications visible even after the network calls have completed, but still afford you the luxury of calling dismiss after the time interval has passed if you need to. For instance: I make network call that I expect to take 1 second, but I want the notification to be visible for 3 seconds. With this method I can set the minimumDuration to 3.0, and then in my completion block for the network call I can still call dismissNotification. The notification will still dismiss after 3 seconds. If the network call takes 5 seconds (poor internet connection) then the dismiss won't get called until the completion block is called at 5 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now set a minimum duration for the notification to display. This allows you to keep notifications visible even after the network calls have completed, but still afford you the luxury of calling dismiss after the time interval has passed if you need to. For instance: I make network call that I expect to take 1 second, but I want the notification to be visible for 3 seconds. With this method I can set the minimumDuration to 3.0, and then in my completion block for the network call I can still call dismissNotification. The notification will still dismiss after 3 seconds. If the network call takes 5 seconds (poor internet connection) then the dismiss won't get called until the completion block is called at 5 seconds.