Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up #139

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Clean up #139

merged 4 commits into from
Aug 1, 2023

Conversation

roysc
Copy link
Collaborator

@roysc roysc commented Jul 21, 2023

Miscellaneous clean-up

  • cleans up the now-unused get_child function,
  • cleans up dockerfiles:
    • deletes docker-compose.test.yml
    • uncomments build section - this is only used as a fallback, so let's just keep it
    • Removes version tag - since this is the source repo for this image, no need to use a specific tag, as this compose file will generally be used for development and testing
  • simplifies the github workflow a bit

@roysc roysc force-pushed the v5-cleanup branch 2 times, most recently from 42186a4 to bd8f52b Compare July 21, 2023 08:36
@roysc roysc marked this pull request as ready for review July 21, 2023 11:32
i-norden
i-norden approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me 👍

@roysc
Drop version tag in docker-compose
59d01ad
@roysc
Simplify docker publish workflow
dcd911a
@roysc
Docker compose cleanup
5b92e02 
- preferred naming convenion is compose.yaml
- test compose was redundant
- uncomment build section for convenience, since it's only used as a fallback
@roysc
Remove get_child function
323ed2d 
Was only used in canonical_header_from_array
@i-norden i-norden merged commit 146282f into cerc-io:v5 Aug 1, 2023
2 checks passed
@roysc roysc deleted the v5-cleanup branch August 1, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-norden i-norden i-norden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roysc @i-norden