Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hypertable down-migration #138

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Fix hypertable down-migration #138

merged 1 commit into from
Aug 1, 2023

Conversation

roysc
Copy link
Collaborator

@roysc roysc commented Jul 21, 2023

Fixes #133 by renaming the indexes back to their original names after migrating out of the hypertables, so that stepping down at 12 will work.
Side note, the storage_leaf_key_index was being dropped but never existed.

Note, this will slightly clobber #137. I can rebase on that if we want to merge it first.

@roysc roysc changed the title Clean up compose files and workflow Fix down-migration and clean up Jul 21, 2023
@roysc roysc changed the title Fix down-migration and clean up Fix hypertable down-migration Jul 21, 2023
Copy link
Collaborator

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Will leave merge order between this and #137 up to you and Thomas.

db/migrations/00012_create_cid_indexes.sql Show resolved Hide resolved
@roysc
Copy link
Collaborator Author

roysc commented Jul 22, 2023

Rebased on @telackey's PR and patched. For some reason I lost write access to this repo, so I can't merge.

@i-norden i-norden merged commit 9196c44 into cerc-io:v5 Aug 1, 2023
2 checks passed
@roysc roysc deleted the v5-dev branch August 1, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hypertables cannot be downgraded
2 participants