Skip to content

Commit

Permalink
Fix docker-compose for publishing image (#91)
Browse files Browse the repository at this point in the history
* Fix docker-compose for publishing image

* Add docker build in pr workflow
  • Loading branch information
nikugogoi authored Jun 14, 2022
1 parent a44724c commit 48eb594
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/on-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ name: Docker Build
on: [pull_request]

jobs:
build:
name: Run docker build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Run docker build
run: make docker-build
test:
# Add a dummy job to avoid failing GitHub CI checks.
# Other checks to be added later.
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ import:
## Build docker image with schema
.PHONY: docker-build
docker-build:
docker-compose build
docker-compose -f docker-compose.test.yml build

## Build docker image for migration
.PHONY: docker-concise-migration-build
Expand Down
5 changes: 2 additions & 3 deletions docker-compose.test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@ services:
restart: on-failure
depends_on:
- ipld-eth-db
image: vulcanize/ipld-eth-db
# Build image using local context
build:
context: .
dockerfile: Dockerfile
build: .
environment:
DATABASE_USER: "vdbm"
DATABASE_NAME: "vulcanize_testing"
Expand Down

0 comments on commit 48eb594

Please sign in to comment.