Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubi8: daemon-base: install without docs #1561

Closed
wants to merge 1 commit into from
Closed

Conversation

mykaul
Copy link

@mykaul mykaul commented Dec 30, 2019

In a container, there's no need to install documentation.
Pass the relevant option for yum to skip documentation installation

Signed-off-by: Yaniv Kaul [email protected]

In a container, there's no need to install documentation.
Pass the relevant option for yum to skip documentation installation

Signed-off-by: Yaniv Kaul <[email protected]>
@mykaul
Copy link
Author

mykaul commented Dec 31, 2019

CI failure is on:
"Error: Failed to synchronize cache for repo 'lab-extras'"
which is true - I can't reach http://apt-mirror.front.sepia.ceph.com/ either :(

So some infra issue.

Copy link
Contributor

@dsavineau dsavineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with this I think this should be done:

  1. not on the yum/dnf CLI but in the configuration.
  2. not only for ubi8 but CentOS 8 too.

And ultimately this should be part of the base image like it is currently present for RHEL/ubi7 and CentOS 7.
I'm wondering why this is not included by default in the latest major release. Maybe dnf set this by default now.

$ docker run --rm centos:7 grep tsflags /etc/yum.conf
tsflags=nodocs
$ docker run --rm centos:8 grep tsflags /etc/yum.conf$ docker run --rm centos:8 grep tsflags /etc/yum.conf
$ docker run --rm registry.access.redhat.com/rhel7 grep tsflags /etc/yum.conf
tsflags=nodocs
$ docker run --rm registry.access.redhat.com/ubi7/ubi:latest grep tsflags /etc/yum.conf
tsflags=nodocs
$ docker run --rm registry.access.redhat.com/ubi8/ubi:latest grep tsflags /etc/yum.conf
$

For me this should be only a workaround until this is fix in the base image.

For CentOS 7 this is done here [1] but for some reason the same thing isn't present in CentOS 8 [2].

[1] https://github.com/CentOS/sig-cloud-instance-build/blob/master/docker/centos-7-x86_64.ks#L100-L102
[2] https://github.com/CentOS/sig-cloud-instance-build/blob/master/docker/centos-8.ks

@dsavineau
Copy link
Contributor

CI failure is on:
"Error: Failed to synchronize cache for repo 'lab-extras'"
which is true - I can't reach http://apt-mirror.front.sepia.ceph.com/ either :(

So some infra issue.

this has been resolved

@mykaul
Copy link
Author

mykaul commented Jan 6, 2020

Asked the CentOS team about 8 - CentOS/sig-cloud-instance-build#167

Of course it should be added to CentOS 8 - thought I'd start with UBI first though.

Not sure why it should be a configuration item, though.

@dsavineau
Copy link
Contributor

Not sure why it should be a configuration item, though.

To avoid adding new yum/dnf commands without this option and because that's the way it's done on ubi 7.

@stale
Copy link

stale bot commented Apr 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 1, 2020
@stale stale bot closed this Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants