Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): update max survival skill from foraging #5579

Merged

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Oct 16, 2024

Checklist

Required

Purpose of change

In an effort to encourage skill training without grinding crafting recipes, I have discovered that foraging bushes is capped by your int score. The current formula seems to be Intelligence divided by 3, plus 1. That means at 12 intelligence you can gain 4 survival from foraging. That's kinda bad as you can grind recipes to level 6 thanks to flint and steel being mainlined. Additionally a 4 int character can only go to level 2.

Describe the solution

The formula is set to intelligence divided by 2 plus one. That means at intelligence 12 you can go to 7, and at int 4 you can go to 3. This also means at level 8 intelligence you can go to level 5, which is around the baseline.

This should allow you to gain more survival without being stuck in a bunker doing crafting, and we can tweak it to be more favorable if that's desired.

Describe alternatives you've considered

Remove the cap by setting it to int divided by 1 + 1, or use int divided by 2 + 2 so it can be respectively at 4, 6, and 8 skill cap. Something for @chaosvolt to consider.

Testing

Tests, because I changed one number on a formula, and I already observed that currently 40 int lets you go to 10 survival.

Additional context

Watch the tests fail because of this. Just watch.

@github-actions github-actions bot added the src changes related to source code. label Oct 16, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems acceptable to me.

@chaosvolt chaosvolt merged commit 07ab5ba into cataclysmbnteam:main Oct 16, 2024
12 checks passed
@RoyalFox2140 RoyalFox2140 deleted the foraging-skill-gain-increase branch October 17, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants