Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 03-organization.md #188

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update 03-organization.md #188

wants to merge 2 commits into from

Conversation

raynamharris
Copy link
Contributor

@raynamharris raynamharris commented Mar 23, 2018

added blurb about templates in the .github directory. Text copied from https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/

@rgaiacs
Copy link
Contributor

rgaiacs commented Mar 24, 2018

The information is in the wrong section.

Starter Files

The bin/lesson_initialize.py script creates files that need to be customized for each lesson:

isn't the right place because https://github.com/swcarpentry/lesson-example/blob/gh-pages/bin/lesson_initialize.py doesn't create the files.

@raynamharris
Copy link
Contributor Author

Thanks, @rgaiacs. I didn't realize that they were all tied to the .py script.

Would these be considered 'helper files'? Or maybe there could be a new section called 'Additional files' or 'Optional files'?

@rgaiacs
Copy link
Contributor

rgaiacs commented Apr 11, 2018

Or maybe there could be a new section called 'Additional files' or 'Optional files'?

+1 for either.

- moved templates to an "optional" section
- added a link to two example templates
@raynamharris
Copy link
Contributor Author

Thanks @rgaiacs. I went with "optional files"

@@ -164,8 +164,10 @@ The `bin/lesson_initialize.py` script creates files that need to be customized f
3. Its permalink must be `/guide/`.
4. It may include whatever content the author thinks appropriate.

# Optional Files Files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be a <h2> so please use ##.

`.github/ISSUE_TEMPLATE.md` and `.github/PULL_REQUEST_TEMPLATE.md`
: When you add an issue and/or pull request templates to your repository, project contributors will automatically see the template's contents in the issue or pull request body. Templates customize and standardize the information you'd like included when contributors contribute. These files can also be stored in `docs` instead of `.github`.
: When you add an issue and/or pull request templates to your repository, project contributors will automatically see the template's contents in the issue or pull request body. Templates customize and standardize the information you'd like included when contributors contribute. These files can also be stored in `docs` instead of `.github`. Here are two example templates for a issues ([1](https://github.com/swcarpentry/r-novice-gapminder/blob/gh-pages/.github/ISSUE_TEMPLATE.md),[2](https://github.com/carpentries/2018-04-bug-bbq/blob/master/.github/ISSUE_TEMPLATE/local-event.md)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples need to be linked to this repository and not a third party one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. Okay, let me think about that for a moment.

@rgaiacs rgaiacs added this to the v9.4.1 milestone Apr 17, 2018
@rgaiacs rgaiacs modified the milestones: v9.5.0, v9.6.0 May 24, 2018
maxim-belkin pushed a commit to maxim-belkin/swc-lesson-example that referenced this pull request Jun 19, 2018
@fmichonneau fmichonneau changed the base branch from gh-pages to main October 13, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants