Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(project): add deprecation notice #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docs(project): add deprecation notice #99

wants to merge 2 commits into from

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Mar 11, 2019 •
edited
Loading

Closes #95

@joshblack joshblack mentioned this pull request Mar 13, 2019
Closed
8 tasks
@joshblack joshblack marked this pull request as ready for review March 13, 2019 16:32
alisonjoseph
alisonjoseph approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 no idea why Travis is failing for this??

@asudoh
Copy link
Contributor

asudoh commented Mar 14, 2019

We probably hit nodejs/node#24985?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @asudoh @alisonjoseph