Store ClientSnapshots in the CapTable. #525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I plan on adding *Snapshot versions and eventually storing snapshots internally.
This seems like an unnecessary complication, and I don't want to deal with it when porting stuff over to snapshots.
...and use it to catch a bug; the test is failing, need to track it down.
Otherwise the target message steals the caps, resulting in errors later when we try to read them.
Per capnproto#523, this is currently failing frequently. Mark it as flaky until we're ready to actually deal with it.
In addition to letting us hand out borrowed references, Storing the snapshots will facilitate code that needs them not to resolve further after AddSnapshot() or SetSnapshot().
|
Marking this as a draft; fussing with this on one of the follow-up features has convinced me that this is a bit error prone: you end up with two things to remember to release, and I'm hitting a cascade of leaks in branch for #480. I may rethink how to do this, time to sleep on it. |
|
I think instead of doing this, I'm going to leave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #522 and #524; review and merge those first. This makes the CapTable hang on to
ClientSnapshotsdirectly, which will be important for addressing the 4-way race in the context of answers.