Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rvm_map_bins should contain rails #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ydkn
Copy link

@ydkn ydkn commented Sep 22, 2014

The rails command should be included in the rvm_map_bins as it is in the capistrano-rbenv gem

@bendilley
Copy link

+1, IMO it makes sense for the rvm extension to match the rbenv one in this regard.

@kirs
Copy link
Member

kirs commented Oct 6, 2014

Not sure about this. capistrano-rvm is trying to be framework agnostic. Should be include sinatra or padrino binaries as well?

@ydkn
Copy link
Author

ydkn commented Dec 18, 2014

Good point. But if capistrano-rvm does not include rails then capistrano-rails has to add itself to rvm_map_bins.
So, it's the same question: Should capistrano-rails be agnostic to Ruby version management tools?

In my opinion it is easier to add it to the capistrano-rvm instead to capistrano-rails.

Btw: sinatra has no binary.

@stevenchanin
Copy link

+1 on including rails in rvm_map_bins.

Not having it there can lead to failures when running remote cap tasks that are hard to figure out & can take a lot of time (e.g. you think "OMG it's something else I've messed up in how my VPS is setup ... let me go dig into what what env is in place when this remote task is run, what PATH's are set, etc, etc")

@dmitry
Copy link

dmitry commented Jan 6, 2017

Please merge this PR. I can confirm rails command should be included in an array map so that some capistrano plugins could work correctly.

@smtlaissezfaire
Copy link

@stevenchanin Agreed - but is the real solution to have better errors? For me, this was just saying "no output" when it should have said "rails: command not found" which would have made this an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants