Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to SPM compatible structure #94 #95

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Migrate to SPM compatible structure #94 #95

wants to merge 2 commits into from

Conversation

7-plus-t
Copy link

Convert the iOS part of the plugin to a SPM compatible structure.

Implements #94

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.

@7-plus-t 7-plus-t mentioned this pull request Jun 28, 2024
Open
@robingenz
Copy link
Member

Thank you for your contribution! I want to get familiar with SPM before merging this.

@TiBz0u
Copy link

TiBz0u commented Nov 14, 2024 •
edited
Loading

Hi @7-plus-t
Maybe we have to consider to add a specific folder in Source/Tests. Don't know why it's done at Capacitor side.

See official plugin from Capacitor.
https://github.com/ionic-team/capacitor-plugins/blob/e12dd0f0969700709258d775a1fe52dce4d5a122/geolocation/Package.swift#L22

Kr.

@7-plus-t
Copy link
Author

I don't know why they did it. From an SPM point of view it's not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@7-plus-t @robingenz @TiBz0u