fix: styles added to incorrectly parsed emoji block #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Q1w1N
force-pushed
the
fix/slack-code-blocks/emoji-parsing-issue
branch
from
eeeff43
to
e70d1d4
Compare
| @@ -149,6 +153,8 @@ export const renderTopLevelTokens = (token: Token, richTextBlocksBuilder: RichTe | |||
| } | |||
| }; | |||
|
|
|||
| const stylableElementTypes = ['channel', 'link', 'text', 'user', 'usergroup']; | |||
There was a problem hiding this comment.
q: How is this code detecting that we are not in a code-block and styling is allowed?
There was a problem hiding this comment.
This only prevents styling an element that should not be styles (also generates invalid_block error).
Styling element inside block is fixed by the line
if (rawText.match(codespanRegex)) {
return [{ type: 'text', text: rawText }];
}
There was a problem hiding this comment.
this is for codespans, what about codeblocks?
Q1w1N
force-pushed
the
fix/slack-code-blocks/emoji-parsing-issue
branch
from
b4b9b3b
to
ebc7f74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added tests and fixed the issue with invalid_blocks
Test plan
Tested with example app and websocket