New fetch #46
Open
New fetch #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to work on Node.js platform v18.14.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the package
grammato be used on environments that use Node.js platform v18. It replacesisomorphic-fetchpackage tonode-fetchpackage.In addition, I noticed that pinging the server through
http://localhost:8081fails on Node.js platform v18 and the server refuses to connect. However, if the base URL ishttp://0.0.0.0:8081, it is able to ping the server. In Node.js platform v16, it does not have problem on usinghttp://localhost:8081.In my fork, I have created workflows to check the compatibility on different versions to ensure that there are no breaking changes. Yet, those workflows are not included in this PR.
Screenshot of successful workflow in my fork
Please let me know if there is something I could improved further. Thank you.