Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: test yarn instead of pnpm #124

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/actions/setup-monorepo/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,11 @@ inputs:
runs:
using: composite
steps:
- name: 🏗 Setup pnpm
uses: pnpm/action-setup@v4
with:
version: ${{ inputs.pnpm-version }}

- name: 🏗 Setup Node
uses: actions/setup-node@v4
with:
node-version: ${{ inputs.node-version }}
cache: pnpm
cache: yarn

- name: 🏗 Setup Expo
uses: expo/expo-github-action@v8
Expand All @@ -39,7 +34,7 @@ runs:
token: ${{ inputs.expo-token }}

- name: 📦 Install dependencies
run: pnpm install
run: yarn install
shell: bash

- name: ♻️ Restore cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
expo-token: ${{ secrets.EXPO_TOKEN }}

- name: 👷 Build packages for mobile
run: pnpm run -w build:mobile
run: yarn run build:mobile

# You can remove this step if you already configured this
# This project shouldn't be pre-configured with this ID, that's why its omitted
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
expo-token: ${{ secrets.EXPO_TOKEN }}

- name: 👷 Build packages
run: pnpm run -w build:mobile
run: yarn run build:mobile

# You can remove this step if you already configured this
# This project shouldn't be pre-configured with this ID, that's why its omitted
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
uses: ./.github/actions/setup-monorepo

- name: ✅ Lint packages
run: pnpm run -w lint
run: yarn run lint

- name: 👷 Build packages
run: pnpm run -w build
run: yarn run build

- name: 🧪 Test packages
run: pnpm run -w test
run: yarn run test
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ node_modules
npm-debug.log
yarn-error.log
package-lock.json
pnpm-lock.yaml
pnpm-workspace.yaml

# Ruby
.direnv
Expand Down
1 change: 0 additions & 1 deletion .npmrc

This file was deleted.

6 changes: 3 additions & 3 deletions apps/mobile/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
"android": "expo run:android",
"ios": "expo run:ios",
"web": "expo start --web",
"eas-build-post-install": "pnpm run -w build:mobile"
"eas-build-post-install": "yarn --cwd ../.. run build:mobile"
},
"dependencies": {
"@acme/feature-home": "workspace:*",
"@acme/feature-home": "1.0.0",
"@expo/metro-runtime": "^3.2.1",
"expo": "^51.0.17",
"expo-dev-client": "~4.0.19",
Expand All @@ -26,7 +26,7 @@
"react-native-web": "~0.19.11"
},
"devDependencies": {
"@acme/eslint-config": "workspace:*",
"@acme/eslint-config": "1.0.0",
"@babel/core": "^7.24.5",
"@types/react": "~18.2.79",
"@types/react-dom": "~18.2.25",
Expand Down
4 changes: 2 additions & 2 deletions apps/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
"start": "next start"
},
"dependencies": {
"@acme/feature-home": "workspace:*",
"@acme/feature-home": "1.0.0",
"next": "^13.2.1",
"react": "~18.2.0",
"react-dom": "~18.2.0",
"react-native-web": "~0.19.6"
},
"devDependencies": {
"@acme/eslint-config": "workspace:*",
"@acme/eslint-config": "1.0.0",
"babel-plugin-react-native-web": "^0.19.6",
"eslint": "^8.34.0",
"eslint-config-next": "^13.2.1"
Expand Down
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"private": true,
"name": "@acme/monorepo",
"workspaces": [
"apps/*",
"packages/*"
],
"scripts": {
"dev": "turbo dev",
"dev:mobile": "turbo dev --filter=\"{./apps/mobile}...\"",
Expand Down
4 changes: 2 additions & 2 deletions packages/feature-home/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
"build": "tsup --clean"
},
"dependencies": {
"@acme/ui": "workspace:*"
"@acme/ui": "1.0.0"
},
"devDependencies": {
"@acme/eslint-config": "workspace:*",
"@acme/eslint-config": "1.0.0",
"@testing-library/react-native": "^12.5.0",
"@tsconfig/recommended": "^1.0.6",
"@types/jest": "^29.5.12",
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"build": "tsup --clean"
},
"devDependencies": {
"@acme/eslint-config": "workspace:*",
"@acme/eslint-config": "1.0.0",
"@testing-library/react-native": "^12.5.0",
"@tsconfig/recommended": "^1.0.6",
"@types/jest": "^29.5.12",
Expand Down
Loading