Feature/slideshow block on node20 wp scripts refactor #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The editor styles are still pretty sad and could use some help :)
…arlie/gut-013-additions
Charlie/gut 013 additions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the 5yr old PR for the slideshow block (#172)
While this is probably 90% functional I don't think it's built as good as it could be or as adaptable as it should be for our needs.
Most slideshow blocks I've seen from others use a parent/child block relationship which I think would provide a better editor experience.
I think it's too tied to a specific animation style and should either be more generic or should we should have more than one slideshow block of different styles.
I think I'd refactor this to use child blocks and be less opinionated on a slideshow style... with a goal of providing a default generic slideshow experience out of the box but with the ability to turn that off and implement a custom JS/layout/animation solution in a child theme. The block could provide the basic mechanism of adding a slideshow and adding photos to it that could work with multiple types of slideshow