Fix to the local variables bug (#12) #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also update many other things
Whereas this fix isn't ideal, it does fix the issue with local variables, I honestly didn't think a lot about a better solution so I am open to suggestions. This commit also fixes a bug with the timeout feature throwing a NPE.
FranKusmiruk
commented
Mar 22, 2019
| @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| zipStoreBase=GRADLE_USER_HOME | |||
| zipStorePath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-all.zip | |||
There was a problem hiding this comment.
I updated the gradle wrapper since I am currently using Java 11, which 3.3 has no support for. I am fine if you want me to revert this change.
|
Sorry for just getting to this now, this fix looks good, though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whereas this fix isn't ideal, it does fix the issue with local
variables, I honestly didn't think a lot about a better solution
so I am open to suggestions.
The aim of the PR besides fixing this bug is: