Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WX-927 JDR DRS resolution #7555

Merged
merged 2 commits into from
Sep 27, 2024
Merged

WX-927 JDR DRS resolution #7555

merged 2 commits into from
Sep 27, 2024

Conversation

mcovarr
Copy link
Contributor

@mcovarr mcovarr commented Sep 23, 2024 •
edited
Loading

Description

Fixed now with scope changes for service accounts.

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@mcovarr mcovarr force-pushed the wx_927_drs_usa branch 2 times, most recently from 5225661 to 797a997 Compare September 25, 2024 23:05
@mcovarr mcovarr changed the base branch from develop to wx_927_google_compute_service_account September 25, 2024 23:05
@mcovarr mcovarr force-pushed the wx_927_google_compute_service_account branch from 5911489 to ace8774 Compare September 26, 2024 05:53
@mcovarr mcovarr changed the title WX-927 Demo broken JDR DRS resolution WX-927 JDR DRS resolution Sep 26, 2024
@mcovarr mcovarr marked this pull request as ready for review September 26, 2024 12:07
@mcovarr mcovarr requested a review from a team as a code owner September 26, 2024 12:07
@mcovarr
Copy link
Contributor Author

mcovarr commented Sep 26, 2024

I believe the patch coverage check failure is due to an incidental fix to the formatting of a log statement.

jgainerdewar
jgainerdewar approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@jgainerdewar jgainerdewar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't totally follow the fix here, what if anything will we need to do to get this to work in prod Terra?

ETA: Oh, I see, just noticing the branch this is being merged to. Looks like the fix is in there and nothing else is needed?

@mcovarr
Copy link
Contributor Author

mcovarr commented Sep 27, 2024

Yes that's right, the wx_927_google_compute_service_account branch contains the scope fixes required for this to work.

@mcovarr mcovarr force-pushed the wx_927_google_compute_service_account branch from 526f613 to 0045108 Compare September 27, 2024 15:53
Base automatically changed from wx_927_google_compute_service_account to develop September 27, 2024 17:27
@mcovarr mcovarr merged commit 9853b52 into develop Sep 27, 2024
36 of 37 checks passed
@mcovarr mcovarr deleted the wx_927_drs_usa branch September 27, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aednichols aednichols aednichols approved these changes

@jgainerdewar jgainerdewar jgainerdewar approved these changes

Assignees
No one assigned
Labels
GCP Batch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcovarr @aednichols @jgainerdewar