Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following:
Description
This PR adds a fix for git clone time outs. The generator breaks after 45 seconds if git clone hasn't completed for wordpress-webpack-workflow. However, there is no indication as to why.
I've added an additional question to the start of the generator asking for a users Internet speed: Fast (30s), Standard (45s), Slow (60s), Slowest (75s) and Custom.
There's an additional prompt if the above error is hit:
While there are no errors with the code, it could potentially be cleaned up.
Related Issue
Issue present in wordpress-plugin-boilerplate:
#brandonkramer/wordpress-plugin-boilerplate#2
Motivation and Context
Initially I assumed it was an issue with path. Backslash instead of forward slash on Windows. After changing that, I got lucky with my internet speed and was able to successfully run the generator in a test folder.
When I returned to my plugins folder and attempted to run the generator, I received the same error.
As this error prevents the generator from running, there should be a justification to why it happened. Along with a way to fix it.
How Has This Been Tested?
Internal testing:
node ./strap.js plugin
node ./strap.js plugin "projectName:Cool Plugin" "description:Test the plugin" "pluginVersion:1.0.0" license:MIT "author:The Dev Company" authorEmail:[email protected] url:www.dev-company.com webpack:Y codesniffer:Y codeception:Y travisCi:Y
node ./strap.js webpack
node ./strap.js webpack "projectName:Cool Plugin" "author:The Dev Company" authorEmail:[email protected] url:www.dev-company.com css:Sass+PostCSS
npx wp-strap plugin
andnpx wp-strap webpack
by editting local files.OS Tested