Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit logs for saas app + admin portal #1972

Closed
wants to merge 39 commits into from
Closed

Audit logs for saas app + admin portal #1972

wants to merge 39 commits into from

Conversation

devkiran
Copy link
Contributor

@devkiran devkiran commented Nov 23, 2023 •
edited
Loading

What does this PR do?

Fixes #651

Audit logs for saas app + admin portal

  • Check fetching IP address is correct
  • Review actions event name are ok

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Existing unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ghost
Copy link

ghost commented Nov 23, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@devkiran devkiran changed the title Feat/audit logs saas app Audit logs for saas app Nov 24, 2023
@devkiran devkiran marked this pull request as ready for review November 27, 2023 07:13
@devkiran devkiran requested a review from a team November 27, 2023 11:18
@devkiran devkiran changed the title Audit logs for saas app Audit logs for saas app + admin portal Nov 28, 2023
niwsa
niwsa reviewed Dec 5, 2023
View reviewed changes
.env.example Outdated Show resolved Hide resolved
@socket-security Socket Security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
request-ip 3.3.0 None +0 10.7 kB pbojinov

@devkiran devkiran requested a review from a team January 3, 2024 13:46
@devkiran devkiran mentioned this pull request Jan 4, 2024
Closed
10 tasks
@deepakprabhakara
Copy link
Member

Closed in favor of #2278

@deepakprabhakara deepakprabhakara deleted the feat/audit-logs-saas-app branch March 19, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niwsa niwsa niwsa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit Logs for Admin Portal
3 participants
@devkiran @deepakprabhakara @niwsa