Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Commit

Permalink
add some TODOs, and fix a broken benchmark
Browse files Browse the repository at this point in the history
  • Loading branch information
bonsairobo committed Oct 26, 2020
1 parent 6f186b6 commit b9af243
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 3 additions & 1 deletion crates/building_blocks_storage/benches/compression.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use building_blocks_core::prelude::*;
use building_blocks_storage::prelude::*;
use building_blocks_storage::{prelude::*, BincodeLz4};

use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};

Expand Down Expand Up @@ -50,3 +50,5 @@ fn set_up_array(size: i32) -> Array3<i32> {
p.x() % 3 + p.y() % 3 + p.z() % 3
})
}

// TODO: report the compression efficiency for some typical data set, like a sphere
1 change: 1 addition & 0 deletions crates/building_blocks_vox/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ pub enum VoxColor {
Empty,
}

// TODO: should take a type parameter that implements a trait to access `VoxColor`
pub fn encode_vox(map: &Array3<VoxColor>) -> DotVoxData {
let global_extent = *map.extent();
let local_extent = global_extent - global_extent.minimum;
Expand Down

0 comments on commit b9af243

Please sign in to comment.