Dev #3
Open
Dev #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
December 13, 2012 14:39
vms may be in the stopping or destroyed state should not be treated as present.
so that subsequent objects can inspect it.
to 600 so that ssh will use them by default
just adds some extra checking to prevent nil exceptions when there are no networks defined.
Adds extra error checking to prevent failures when there are not key pairs defined.
b/c some of the properties being set are not set in the resource, but parsed from the creation response.
This resource supports installing puppet enterprise, and classifying agents.
to demonstrate creation of supported objects.
cleans up some commented out code, fixes formatting
so that you can refer to previously created key pairs. also, ensure that any specified key pairs are auto-required.
|
@ke4qqq do you mind reviewing this and giving me the +1 to merge? Don't worry about the puppet_node stuff, I am probably going to rip it out and make it a separate project. |
|
Yeah - I'll look at it next week. |
|
@ke4qqq if you want to set up a time, it could go faster if we just paired on this for a couple of hours. |
|
I never quite looped back around to it and don't have a cloudstack environment to test against. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.