Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Odo documentation/code for sqlalchemy_redshift #489

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Odo documentation/code for sqlalchemy_redshift #489

wants to merge 2 commits into from

Conversation

RAbraham
Copy link

This request combines the work of two authors to update documentation and code to refer to sqlalchemy_redshift

RAbraham and others added 2 commits October 18, 2016 12:50
@RAbraham
Copy link
Author

@branning I don't know if you get notifications from this PR, but in case you don't, Travis failed on a change made for the travis file commit.

@branning
Copy link
Contributor

It's because Spark 1.4 and 1.5 aren't available any more (they're very old by now). That's not something we changed. You'll notice that all recent Travis runs have the same problem. Not sure there's much we can do in the context of this PR. Odo's automated testing is basically completely broken.

@branning
Copy link
Contributor

@RAbraham it looks like the tests are passing now on other PRs. I think we can give this another try. You'll need to pull in the newest commits to blaze/odo that fixed the tests. If it were me, I'd do this:

After changing the target branch, the PR should update automatically. I believe Travis will start again at that point, and we can see if we can get this PR green! 🍏

@llllllllll
Copy link
Member

We changed how we setup travis so that we don't have this spark issue again. Instead of putting this in the conda call in the .travis file can you move this into a new install target like etc/requirments_redshift.txt and then add redshift to the list in extras_require in setup.py. You will also want to put the strictly equals version in requirements_ci.txt This is so that we call all reproduce the versions installed when running the automated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants