Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14461] Update organization state after subscription update #12222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amorask-bitwarden
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden commented Dec 3, 2024

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-14461

๐Ÿ“” Objective

This PR updates the updatePasswordManagerSeats invocation in the organization-api.service to take in a ProfileOrganizationResponse from the server. It then uses that response to update the organization state after the organization's seats have been updated.

Server PR: bitwarden/server#5103

๐Ÿ“ธ Screenshots

Screen.Recording.2024-12-03.at.12.41.58.PM.mov

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 923a6a97-e515-40c0-b7ac-11a59ff3fbe8

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 33.51%. Comparing base (9188a31) to head (6c4e83d).
Report is 2 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ing/organizations/adjust-subscription.component.ts 0.00% 7 Missing โš ๏ธ
.../services/organization/organization-api.service.ts 0.00% 2 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12222   +/-   ##
=======================================
  Coverage   33.50%   33.51%           
=======================================
  Files        2884     2884           
  Lines       90131    90164   +33     
  Branches    17142    17150    +8     
=======================================
+ Hits        30198    30218   +20     
- Misses      57547    57556    +9     
- Partials     2386     2390    +4     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants