Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-506] Upgrade to Angular 18 #12218

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[CL-506] Upgrade to Angular 18 #12218

wants to merge 5 commits into from

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Dec 3, 2024

🎟️ Tracking

CL-506

📔 Objective

This PR upgrades our version of Angular to 18, including all peer modules.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Logo
Checkmarx One – Scan Summary & Detailsaf0102a4-1d3a-415d-b1a1-6ece5113d9a1

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 876

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (c073e91) to head (762953f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/app.module.ts 0.00% 1 Missing ⚠️
bitwarden_license/bit-web/src/app/app.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12218   +/-   ##
=======================================
  Coverage   33.51%   33.52%           
=======================================
  Files        2886     2886           
  Lines       90185    90185           
  Branches    17150    17150           
=======================================
+ Hits        30230    30237    +7     
+ Misses      57565    57558    -7     
  Partials     2390     2390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vleague2 vleague2 changed the title Ds/cl 506/angular 18 [CL-506] Upgrade to Angular 18 Dec 3, 2024
@vleague2 vleague2 marked this pull request as ready for review December 3, 2024 20:20
@vleague2 vleague2 requested a review from a team as a code owner December 3, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant