[PM-14206] State value race condition when subscribing for first time

[mzieniukbw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14206

📔 Objective

When subscribing to the observable, where there have been an update to the state, the current state value and updates values race together due to merge operator. The behaviour on which one resolves first is random.

Changed the operator to concat to always get sequential observables. Since updates observable holds the newest value, changed this operator to be first, which current value from store as fallback.

Unit Tests coverage yet to be improved.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – a052de1b-0d57-4534-87a7-142f7ec43d86

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Client_JQuery_Deprecated_Symbols	/apps/cli/src/service-container/service-container.ts: 876	Attack Vector

[mzieniukbw]

Converting to draft since tests seems to be failing. Need to investigate.