Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10413] ssh keygen on web and browser #12176

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Nov 28, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10413

📔 Objective

Removes ssh-keygen from desktop native and switches over to using the sdk. Further, this adds ssh-keygen support on all clients.

📸 Screenshots

Screen.Recording.2024-11-28.at.14.29.30.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten changed the title [PM-10413] ssh keygen web client [PM-10413] ssh keygen on web and browser Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

Logo
Checkmarx One – Scan Summary & Details21be0a41-b93e-4a5a-b03e-41c03055ba7c

No New Or Fixed Issues Found

@quexten quexten marked this pull request as ready for review November 28, 2024 13:49
@quexten quexten requested review from a team as code owners November 28, 2024 13:49
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 24.48980% with 37 lines in your changes missing coverage. Please review.

Project coverage is 33.51%. Comparing base (9c03cff) to head (1b5c3e9).

Files with missing lines Patch % Lines
...angular/src/vault/components/add-edit.component.ts 0.00% 18 Missing ⚠️
...ponents/sshkey-section/sshkey-section.component.ts 18.75% 13 Missing ⚠️
...ew-item-dropdown/new-item-dropdown-v2.component.ts 75.00% 0 Missing and 2 partials ⚠️
...s/vault-item-dialog/vault-item-dialog.component.ts 0.00% 2 Missing ⚠️
...vault/popup/components/vault/add-edit.component.ts 0.00% 1 Missing ⚠️
.../desktop/src/vault/app/vault/add-edit.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12176   +/-   ##
=======================================
  Coverage   33.51%   33.51%           
=======================================
  Files        2884     2884           
  Lines       90123    90146   +23     
  Branches    17139    17146    +7     
=======================================
+ Hits        30205    30213    +8     
- Misses      57532    57543   +11     
- Partials     2386     2390    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dani-garcia
dani-garcia previously approved these changes Dec 2, 2024
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over code and it looks like good work was done. I am a new hire so if you'd like more senior eyes on this please let me know and I'll rope in someone.

@quexten
Copy link
Contributor Author

quexten commented Dec 3, 2024

Resolved merge conflicts; also note: Removed the "regenerate" button, after this came up as a potential confusing point in a meeting. So ssh keys are now only generated when creating a new item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants