-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-10413] ssh keygen on web and browser #12176
base: main
Are you sure you want to change the base?
Conversation
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12176 +/- ##
=======================================
Coverage 33.51% 33.51%
=======================================
Files 2884 2884
Lines 90123 90146 +23
Branches 17139 17146 +7
=======================================
+ Hits 30205 30213 +8
- Misses 57532 57543 +11
- Partials 2386 2390 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over code and it looks like good work was done. I am a new hire so if you'd like more senior eyes on this please let me know and I'll rope in someone.
Resolved merge conflicts; also note: Removed the "regenerate" button, after this came up as a potential confusing point in a meeting. So ssh keys are now only generated when creating a new item. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10413
📔 Objective
Removes ssh-keygen from desktop native and switches over to using the sdk. Further, this adds ssh-keygen support on all clients.
📸 Screenshots
Screen.Recording.2024-11-28.at.14.29.30.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes