-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API changes proposal #37
Open
gabriel-alecu
wants to merge
16
commits into
bitly:master
Choose a base branch
from
gabriel-alecu:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6505a08
Added GetPathAny(), which is like GetPath(), but can also go through …
110b96b
Added MapJson() and ArrayJson()
287f6fb
Some naming and comment edits.
70959dc
Added MustJsonMap() and MustJsonArray()
bb58a70
(COMP BREAK) Reworked the Get() methods
cfb04ab
Removed StringArray()
d6f7ad3
Changed the cast methods
f48d285
Fixed missing return error in go 1.0.3
a487d55
Removed misplaced prefix from CheckInterface()
0030fe8
Renamed *Json*() methods to *JSON*()
bbcf290
Removed CheckBytes()
ea30edb
Check*() methods now return a bool instead of an error
246029b
Fixed a missed go1.0 bug
880249d
Renamed Json type to JSON
2a47cd5
Renamed NewJson to NewJSON()
6c0cf65
Forgot to update the tests :P
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just update
GetPath
to behave like this, it won't be backwards incompatible...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I tried that at first, but one of the tests gave an error about converting []string to []interface{}, so it's not fully compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, when passing
v...
as the argument wherev
is[]string
, hmmmm