Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: eliminate legacy openssl provider #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivan-zynesis
Copy link

@ivan-zynesis ivan-zynesis commented Mar 3, 2023

What has been done

  • Bump bs58check dependency to v3 which change createHash implementation to use @noble/hashes
  • Use @noble/hashes

Why

Allow usage of this library in node v18 without requiring --openssl-legacy-provider flag.

@ivan-zynesis ivan-zynesis force-pushed the remove-node16-openssl-dependencies branch from 281b3c8 to fb30ef2 Compare March 3, 2023 06:46
@ivan-zynesis ivan-zynesis force-pushed the remove-node16-openssl-dependencies branch from fb30ef2 to daaa87d Compare March 3, 2023 06:46
@ivan-zynesis ivan-zynesis changed the title Dependency: bump bs58check to v3 Dependency: eliminate legacy openssl provider Mar 8, 2023
@ivan-zynesis
Copy link
Author

Hi @junderw, any chance we can get this reviewed and iterate to be mergable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant