Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 plot_Distribution report wrong labels with classes based mean graphs #42

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

bunop
Copy link
Contributor

@bunop bunop commented May 25, 2023

Description

This PR try to classify ROH with an internal function and correctly labels classes for classes based stuff in plot_Distribution and summaryRuns

Related Issue

this will solve #41

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.53 🎉

Comparison is base (567859e) 59.01% compared to head (5f79155) 61.55%.

❗ Current head 5f79155 differs from pull request most recent head 09b957f. Consider uploading reports for the commit 09b957f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel      #42      +/-   ##
==========================================
+ Coverage   59.01%   61.55%   +2.53%     
==========================================
  Files           6        6              
  Lines        1359     1329      -30     
==========================================
+ Hits          802      818      +16     
+ Misses        557      511      -46     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant