Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👽 set guides(fill="none") in plot_InbreedingChr and plot_DistributionRuns #40

Merged
merged 1 commit into from
May 9, 2023

Conversation

bunop
Copy link
Contributor

@bunop bunop commented Apr 28, 2023

Description

This PR seems to solve a warning raised by ggplot2 when plotting graphs with plot_InbreedingChr and plot_DistributionRuns

Related Issue

close #39

Motivation and Context

This change is require to remove the warning (and maybe a future incompatibility)

How Has This Been Tested?

This has been tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…Runs

Set guides(fill="none") since ggplot2 deprecated guides(fill=FALSE)
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (1f821bc) 50.91% compared to head (f53d7ed) 50.91%.

❗ Current head f53d7ed differs from pull request most recent head 79b04a6. Consider uploading reports for the commit 79b04a6 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##            devel      #40   +/-   ##
=======================================
  Coverage   50.91%   50.91%           
=======================================
  Files           6        6           
  Lines        1259     1259           
=======================================
  Hits          641      641           
  Misses        618      618           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@filippob filippob merged commit 466f55a into devel May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants