-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡ refactor tableRuns to better manage memory #32
Conversation
snpInsideRuns(Cpp) is now internal
check runs where SNP are major or equal the threshold specified
rewrite code to calculate percentages correctly
Codecov Report
@@ Coverage Diff @@
## devel #32 +/- ##
==========================================
+ Coverage 50.91% 58.86% +7.94%
==========================================
Files 6 6
Lines 1259 1354 +95
==========================================
+ Hits 641 797 +156
+ Misses 618 557 -61
Continue to review full report at Codecov.
|
correctly skip empty subset
Description
tableRuns
are now calculated on each chromsome one-by-one. Code was revisited to better manage resources and calculate percentages properly.snpInsideRunsCpp
is no more exported, so it's not possible to provide directly its results totableRuns
Related Issue
closes #31
closes #36
Motivation and Context
tableRuns
consume a lot of memory especially when applied to WGS data. By calculating snpInsideRuns on each chromosome and immediately filtering runs lower the memory usageHow Has This Been Tested?
Code has been tested with CI and by manually checking results
Types of changes
Checklist: