Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ refactor tableRuns to better manage memory #31

Open
7 tasks done
bunop opened this issue Mar 28, 2022 · 0 comments · May be fixed by #28
Open
7 tasks done

⚡ refactor tableRuns to better manage memory #31

bunop opened this issue Mar 28, 2022 · 0 comments · May be fixed by #28

Comments

@bunop
Copy link
Contributor

bunop commented Mar 28, 2022

Is your feature request related to a problem? Please describe.
tableRuns consume a lot of memory especially when applied to WGS data

Describe the solution you'd like
Rewrite function to manage memory better, for example calculating data by chromosomes without store values in memory

Describe alternatives you've considered
Since SNPs in runs below the supplied threshold are discarded, we could filter directly those SNPs in snpInsideRunsCpp

Additional context

  • add test code for tableRuns
  • remove SnpInRuns as input parameter (snpInsideRuns is now internal)
  • filter SNPs after snpInsideRunCpp or in snpInsideRunsCpp
  • apply all the steps by chromosomes
  • implement tableRuns in cpp
  • remove unused R code
  • readPOPcpp once and apply the same pop object to snpInsideRunCpp
@bunop bunop changed the title ⚡ refactor tableRuns to manage memory better ⚡ refactor tableRuns to better manage memory Apr 4, 2022
@bunop bunop linked a pull request May 9, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant