-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement context fusion #60
base: geo_upload
Are you sure you want to change the base?
Conversation
this.overlays = biigle.$require('annotations.overlays'); | ||
// console.log('geoOverlays: ', this.overlays); | ||
// console.log('activeId: ', this.settings); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzur,
I am a bit confused by all the imports between the biigle modules, which is why I pose this question:
In the geo-module I created a ContextLayerMixin
for the annotationCanvas.vue
of biigle/core.
In this mixin, I want to access a couple of variables from the annotation settings tab (i.e. the activeId or opacity of the geo-overlay settings, which are part of yet another plugin that is published from the geo-module to the settingsTab.vue
in core).
In order to access these variables, do I have to make them available as properties in the annotationCanvas
component (here) in biigle/core, or can I directly import them, for example the whole settings-variable from the settings-store?
The first option should work because the variables would be made accessible within the ContextLayerMixin
, but it would require changes to the code in biigle/core, which doesn't seem right. Regarding the second option, I'm not sure how to make the settings-store variable available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point, there is no direct way to access the settings in an annotation canvas mixin. Maybe you can do it like the reports module. It does everything in the settings tab plugin by using the annotations.map.init
and images.change
events to hook up OpenLayers objects and update image data.
…on settings-store.
return tileLayer; | ||
}, | ||
updateCurrentImage(id, image) { | ||
this.currentImage = image; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzur,
when metadata is provided for the volume, what is the currently implemented way to access the metadata for each image (i.e. the point geo-coordinate)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image model has the attributes lat
and lng
. Other metadata must be accessed via $image->metadata
.
…-layer extent (pixel).
…t corner of an image as reference)
@mzur, I'll forward you the example dataset + computed metadata-file for testing purposes. |
Refers to #45