Improve the usability of the base docker #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were no default configurations for this image. I have now added 2 configurations that expect a container linked as 'zookeeper' to be available.
I have also changed the start command for the docker image.
The original implementation already used JSON.loads to load the JSON file containing the array with objects to be converted to shell commands. There is an issue with this when there are multiple keys with the same value. In that case only the last value was retained. I have now changed the behavior to allow for the inclusion of an array that will be expended to a repetition of the same key with different arguments. The case where there is a need to have a single key with an array of arguments is also supported although in that case the arguments have to be provided in the array form they would take in the shell command (the shell command is built using string concatenation). Lastly this commit also adds documentation to this process within the python script.
Since the start up of kafka blocks the rest of the script to be executed I have moved to init process to a different process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were no default configurations which would make this image easier to use.
I have also added and updated documentation.
Lastly I have changed the way the JSON objects are converted to shell commands to resolve the multiple key issue (see commits for more information). And added a default listener.