Add support for negative ranges in classes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change [\D] was treated the same as [\d] because the complement flag was lost. After this change [\D] correctly represents the set of non-\d characters. This also enables [\d\D] to match every single character. Fixes bd82#66
|
Hello @ConradIrwin Thanks for the PR. The reason I am asking is that I am interested in deprecating this library and replacing its usage in Chevrotain with regexpp. |
|
I'm using it directly, because I'm building tools that analyze regular expressions. If you think Thanks for your work on this so far, it got me up and running! |
|
Thanks @ConradIrwin , Please let me know if you have any issues with |
|
We'll find out :D.
…On Mon, Jul 06, 2020 at 12:39 AM, Shahar Soel < ***@***.*** > wrote:
Thanks @ ConradIrwin ( https://github.com/ConradIrwin ) , Please let me
know if you have any issues with regexpp the main reason
I want to use it is to reduce TCO and need to maintain this library... I
don't know how good or not it is yet 😄 .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
#67 (comment) ) , or
unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAAXAQGEA6SOJR3BSPTMORLR2F5TTANCNFSM4OQRE5TQ
).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change [\D] was treated the same as [\d] because the
complement flag was lost.
After this change [\D] correctly represents the set of non-\d
characters.
This also enables [\d\D] to match every single character.
Fixes #66