Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

adaRn
Copy link

@adaRn adaRn commented Nov 15, 2016

Prioritise Docker section, as this file is also automatically shown in Docker Hub as an image description. In the future it'd be nice to move Dockerfile to the docker directory. Then we could have Readme specific for Dockerhub.
Also, general clean-up of commands and sections and typos.

Prioritise Docker section, as this file is also automatically shown in Docker Hub as an image description. In the future it'd be nice to move Dockerfile to the docker directory. Then we could have Readme specific for Dockerhub.
Also, general clean-up of commands and sections and typos.
@adaRn
Copy link
Author

adaRn commented Nov 25, 2016

@bbinet Hey, can you check that out?

Copy link
Owner

@bbinet bbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I'm not in favor of prioritizing the Docker section and moving it to the top.
But we could add a line at the top, to point docker users to the docker section at the bottom of the file.

README.rst Outdated
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The command below will pull the image from the Docker Hub if it's not already downloaded
and run `Reverse-ssh-manager` in a Docker containter named `rsm`.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/containter/container/

@adaRn
Copy link
Author

adaRn commented Dec 24, 2016

How is it now @bbinet ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants