-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.rst #1
base: master
Are you sure you want to change the base?
Conversation
Prioritise Docker section, as this file is also automatically shown in Docker Hub as an image description. In the future it'd be nice to move Dockerfile to the docker directory. Then we could have Readme specific for Dockerhub. Also, general clean-up of commands and sections and typos.
@bbinet Hey, can you check that out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but I'm not in favor of prioritizing the Docker section and moving it to the top.
But we could add a line at the top, to point docker users to the docker section at the bottom of the file.
README.rst
Outdated
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
The command below will pull the image from the Docker Hub if it's not already downloaded | ||
and run `Reverse-ssh-manager` in a Docker containter named `rsm`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/containter/container/
s/containter/container
How is it now @bbinet ? :) |
Prioritise Docker section, as this file is also automatically shown in Docker Hub as an image description. In the future it'd be nice to move Dockerfile to the docker directory. Then we could have Readme specific for Dockerhub.
Also, general clean-up of commands and sections and typos.