Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass along output_base to bazel invocations in gen_rust_project #2933

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexkirsz
Copy link
Contributor

If a custom Bazel output_base is passed to gen_rust_project through the --output-base CLI option, the tool should pass along this output_base to all downstream Bazel invocations.

In this case, there are two:

bazel info

and

bazel build --aspects={}//rust:defs.bzl%rust_analyzer_aspect

Without this, invoking the following results in an empty rust-project.json:

bazel --output_base=$OUTPUT_BASE run @rules_rust//tools/rust_analyzer:gen_rust_project -- --output-base=$OUTPUT_BASE -- $TARGETS

It would be even better if the tool could somehow read its output_base from the original bazel invocation.

@alexkirsz alexkirsz force-pushed the alexkirsz/rust-project-output-base branch from 9e7f14d to 8518c03 Compare October 14, 2024 17:25
@alexkirsz alexkirsz force-pushed the alexkirsz/rust-project-output-base branch from 8518c03 to 997d9f7 Compare October 17, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant