Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated attribute #2811

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −45
Draft

Drop deprecated attribute #2811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ed667f
Drop deprecated attribute
scentini Aug 26, 2024
87b4ceb
Also drop attribute from test rules
scentini Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions rust/private/rust.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,9 +888,6 @@ rust_static_library = rule(
doc = "Optional platform to transition the static library to.",
default = None,
),
"_allowlist_function_transition": attr.label(
default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
),
}.items()),
fragments = ["cpp"],
cfg = _rust_static_library_transition,
Expand Down Expand Up @@ -934,9 +931,6 @@ rust_shared_library = rule(
doc = "Optional platform to transition the shared library to.",
default = None,
),
"_allowlist_function_transition": attr.label(
default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
),
"_use_grep_includes": attr.bool(default = True),
}.items()),
fragments = ["cpp"],
Expand Down Expand Up @@ -980,9 +974,6 @@ rust_proc_macro = rule(
# https://docs.bazel.build/versions/main/skylark/config.html#user-defined-transitions.
attrs = dict(
_common_attrs.items(),
_allowlist_function_transition = attr.label(
default = Label("//tools/allowlists/function_transition_allowlist"),
),
deps = attr.label_list(
doc = dedent("""\
List of other libraries to be linked to this library target.
Expand Down Expand Up @@ -1066,9 +1057,6 @@ rust_binary = rule(
doc = "Optional platform to transition the binary to.",
default = None,
),
"_allowlist_function_transition": attr.label(
default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
),
}.items()),
executable = True,
fragments = ["cpp"],
Expand Down Expand Up @@ -1208,9 +1196,6 @@ rust_binary_without_process_wrapper = rule(
doc = "Optional platform to transition the binary to.",
default = None,
),
"_allowlist_function_transition": attr.label(
default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
),
}.items()),
executable = True,
fragments = ["cpp"],
Expand Down Expand Up @@ -1255,9 +1240,6 @@ rust_test = rule(
doc = "Optional platform to transition the test to.",
default = None,
),
"_allowlist_function_transition": attr.label(
default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
),
}.items()),
executable = True,
fragments = ["cpp"],
Expand Down
3 changes: 0 additions & 3 deletions rust/private/transitions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,5 @@ alias_with_import_macro_bootstrapping_mode = rule(
cfg = import_macro_dep_bootstrap_transition,
mandatory = True,
),
"_allowlist_function_transition": attr.label(
default = Label("//tools/allowlists/function_transition_allowlist"),
),
},
)
3 changes: 0 additions & 3 deletions rust/private/unpretty.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,6 @@ rust_unpretty = rule(
values = _UNPRETTY_MODES,
default = "expanded",
),
"_allowlist_function_transition": attr.label(
default = Label("//tools/allowlists/function_transition_allowlist"),
),
"_unpretty_modes": attr.label(
doc = "The values to pass to `--unpretty`",
providers = [RustUnprettyInfo],
Expand Down
3 changes: 0 additions & 3 deletions test/cargo_build_script/symlink_exec_root/symlink_exec_root_transition.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ symlink_execroot_cargo_build_script = rule(
mandatory = True,
providers = [BuildInfo],
),
"_allowlist_function_transition": attr.label(
default = Label("//tools/allowlists/function_transition_allowlist"),
),
},
cfg = symlink_execroot_setting_transition,
)
3 changes: 0 additions & 3 deletions test/extra_exec_rustc_flags/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ with_extra_exec_rustc_flags_cfg = rule(
allow_files = True,
cfg = _extra_exec_rustc_flags_transition,
),
"_allowlist_function_transition": attr.label(
default = Label("//tools/allowlists/function_transition_allowlist"),
),
},
)

Expand Down
5 changes: 0 additions & 5 deletions test/unit/is_proc_macro_dep/is_proc_macro_dep_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,6 @@ attach_dep_actions_and_enable_is_proc_macro_dep_aspect = rule(
"dep": attr.label(
aspects = [collect_dep_actions_aspect],
),
"_allowlist_function_transition": attr.label(
default = Label(
"//tools/allowlists/function_transition_allowlist",
),
),
},
cfg = enable_is_proc_macro_dep_transition,
)
Expand Down
4 changes: 0 additions & 4 deletions tools/allowlists/function_transition_allowlist/BUILD.bazel
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions wasm_bindgen/private/wasm_bindgen.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,6 @@ WASM_BINDGEN_ATTR = {
cfg = wasm_bindgen_transition,
mandatory = True,
),
"_allowlist_function_transition": attr.label(
default = Label("//tools/allowlists/function_transition_allowlist"),
),
}

rust_wasm_bindgen = rule(
Expand All @@ -148,9 +145,6 @@ An example of this rule in use can be seen at [@rules_rust//examples/wasm](../ex
cfg = wasm_bindgen_transition,
mandatory = True,
),
"_allowlist_function_transition": attr.label(
default = Label("//tools/allowlists/function_transition_allowlist"),
),
},
toolchains = [
str(Label("//wasm_bindgen:toolchain_type")),
Expand Down
Loading