issue: 882 #884
issue: 882 #884
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sjonnalagadda
force-pushed
the
main
branch
2 times, most recently
from
f7574a8
to
d15d998
Compare
Upgrading rules_python version and fixed a regression test issue
| @@ -7,7 +7,7 @@ module( | |||
|
|
|||
| # Do not update to newer versions until you need a specific new feature. | |||
| bazel_dep(name = "rules_license", version = "0.0.7") | |||
| bazel_dep(name = "rules_python", version = "0.31.0") | |||
| bazel_dep(name = "rules_python", version = "0.34.0") | |||
There was a problem hiding this comment.
Can you explain why we need this version bump?
There was a problem hiding this comment.
I tried to keep it uniform. The consumers of rules_pkg will get rules_python 0.34.0. So, if rules_pkg also need a version of rules_python for it's build, then let the build also use same version.
There was a problem hiding this comment.
My question is whether there is a feature in rules_python 0.34.0 that rules_pkg is now using? In general for bzlmod, rulesets should declare the minimum viable version for their dependencies. This allows clients to dictate the version of a dependency.
There was a problem hiding this comment.
+1 I am very dubious about this. It pulls in rules_python internal things.
That may work at this instant in time, but it feels brittle w.rt. new versions.
Upgrading rules_python version and fixed a regression test issue
Fix for issue: #882