Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing #763 #770

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

testing #763 #770

wants to merge 1 commit into from

Conversation

aiuto
Copy link
Collaborator

@aiuto aiuto commented Oct 31, 2023

@kellyma2

I'm baffled. I took the example you had and added a python version of the binary.

python alone works fine. C++ fails with a permission denied error, not file not found.

I added some debugging "ls -l"s into the install stanza and the files seem to be in the source. I can't spend a lot of time on it this week, but it seems that the permission problem is while calling /usr/bin/strip. It might be that the file is mode o555 rather than o755. But.. how has this been working for others?

@kellyma2
Copy link
Contributor

I'll take a bit closer look at this either tomorrow or Thursday to see if I can narrow down what's going on for me a bit. Are you able to share a bit more detail about the environment in which you're testing this?

@aiuto
Copy link
Collaborator Author

aiuto commented Oct 31, 2023

Debian 6.5.3, bazel 6.4.0
RPM version 4.18.0

And, now that I list the rpmbuild version, I remember that rpmbuild has some breaking changes between versions. That may be a clue. What do you have?

@kellyma2
Copy link
Contributor

kellyma2 commented Nov 1, 2023

Debian 6.5.3, bazel 6.4.0 RPM version 4.18.0

And, now that I list the rpmbuild version, I remember that rpmbuild has some breaking changes between versions. That may be a clue. What do you have?

bazel 6.3.2, rpmbuild 4.14.3, custom-ish Linux based on CentOS. I'll test against vanilla Fedora/CentOS tomorrow with newer rpmbuild and see what I get.

@aiuto
Copy link
Collaborator Author

aiuto commented Nov 1, 2023

@nacl
IIRC, there were some changes between recent rpmbuild versions which we had to work around to achieve backwards compatibility. One was around SOURCE_DATE_EPOCH at 4.14.0

This line suggests that something on either side of 4.16 required putting the version in the toolchain declaration. And lo, you are 4.14 and I am 4.18, so that's a lead.

Sometimes I wonder if we should just have done #662.

@aiuto aiuto added the P3 An issue that we are not working on but will review quarterly label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 An issue that we are not working on but will review quarterly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants