Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move static library validation helper to ar_files #257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move static library validation helper to ar_files #257

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Oct 15, 2024

It doesn't need to be staged for every compile or link action. The action that uses it stages all_files.

@fmeum
Move static library validation helper to ar_files
12a8bd5 
It doesn't need to be staged for every compile or link action. The action that uses it stages `all_files`.
@fmeum
Copy link
Contributor Author

fmeum commented Oct 15, 2024

A local run of buildifier -lint=warn -r . doesn't show any findings, but the CI run fails (without output). Not sure what to do about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil Awaiting requested review from oquenchil oquenchil is a code owner

@c-mita c-mita Awaiting requested review from c-mita c-mita is a code owner

@comius comius Awaiting requested review from comius comius is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fmeum