Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change function visibility of run() from public to external #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ATella12
Copy link

Updated the visibility of the run() function in the TestWithdraw contract from public to external. This change improves gas efficiency by restricting the function to external calls only, as it is intended to be invoked by external contracts or accounts. No other functionality or logic in the contract has been altered.

Updated the visibility of the run() function in the TestWithdraw contract from public to external. This change improves gas efficiency by restricting the function to external calls only, as it is intended to be invoked by external contracts or accounts. 
No other functionality or logic in the contract has been altered.
@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@GHOST198991
Copy link

Updated the visibility of the run() function in the TestWithdraw contract from public to external. This change improves gas efficiency by restricting the function to external calls only, as it is intended to be invoked by external contracts or accounts. No other functionality or logic in the contract has been altered.

Good looking out.
I appreciate that.

@cb-heimdall
Copy link
Collaborator

Review Error for GHOST198991 @ 2024-11-04 22:56:49 UTC
User must have write permissions to review

@cb-heimdall
Copy link
Collaborator

Review Error for GHOST198991 @ 2024-11-04 22:57:12 UTC
User must have write permissions to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants