Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue/429): update banner-card, info-card, with-maps components #431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EinfachAleks
Copy link
Collaborator

Closes #428

@KirDE
Copy link
Contributor

KirDE commented Nov 10, 2024

I don't think that "Show more" is really needed. Also it doesn't work well right now, for short description it hides the half, for long japanese it does nothing. In my opinion can be removed again.

@KirDE
Copy link
Contributor

KirDE commented Nov 10, 2024

image
image
image
image
breaks the lines
if description too short, ot shows nothing but button is always there.

We don't need it at all.

@EinfachAleks
Copy link
Collaborator Author

@KirDE I agree with you on some points, but unfortunately not on others.
But that's not the point, I wanted to help in a solution-oriented way!

Please describe or draw me how you imagine your ideal solution, because the information/description of the problem message is not enough for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long banner description with scroll doesn't fit into column on desktop
2 participants