Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a 404 on a link to the WPE site #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix a 404 on a link to the WPE site #63

wants to merge 2 commits into from

Conversation

jornh
Copy link

@jornh jornh commented Oct 7, 2019

Looks like it's not living at Igalia anymore - but there's a new nice page under webkit.org

@jornh
Fix a 404 on a link to the WPE site
c1f345e 
Looks like it's not living at Igalia anymore - but there's a new nice page under webkit.org
@chrisys
Copy link
Member

chrisys commented Jan 2, 2020

@jornh thanks for the contribution! Could you update the message on your commit (not the PR) to include the footer: Change-type: patch ?

@jornh
Update README.md
898b99c 
Change-type: patch
@jornh
Copy link
Author

jornh commented Jan 2, 2020

@chrisys yes, sure! By “into to footer“ I’m guessing you mean it has to go into any subsequent commit line like I did in my second commit 898b99c ?

@chrisys
Copy link
Member

chrisys commented Jan 3, 2020

@balena-ci retest

1 similar comment
@tmigone
Copy link

tmigone commented Nov 19, 2020

@balena-ci retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisys chrisys chrisys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jornh @chrisys @tmigone